Ticket #295 (closed Bugs: fixed)

Opened 14 months ago

Last modified 2 weeks ago

Ogg vorbis remaining time not correctly estimated

Reported by: rmcauley Owned by: toots
Priority: 5 Milestone:
Component: Liquidsoap Version:
Keywords: Cc:
Mac OSX: yes Linux: yes
NetBSD: yes Other Operating System: yes
FreeBSD: yes

Description (last modified by toots) (diff)

When using request-based sources with conservative=false enabled, ogg/vorbis remaining time seems to be very low.

More in details, the new mechanism implies that after the first #get_frame, the estimated remaining time be high enough to no trigger a new request.

While it seems to work correctly with mp3 files and a length of 10 seconds, ogg/vorbis estimated time seems to be very low after the first #get_frame. Here, I need to set length to 0.6 make it work.

Using ocaml-vorbis, it is possible to have a better estimation, which, contrary to the mp3 case, does not seem to be too high in terms of CPU usage.

Change History

Changed 14 months ago by toots

  • owner changed from admin to toots
  • priority changed from 1 to 5
  • description modified (diff)
  • summary changed from request.dynamic conservative=false does not use estimated remaining time to Ogg vorbis remaining time not correctly estimated

Changed 14 months ago by metamorph68

  • status changed from new to closed
  • resolution set to fixed

(In [6691]) Added buffer's remaining time when computing estimated remaining time. fixes #295. Some remarks:

  • Adding precise estimated time is complicated, in particular due to the stream muxing.
  • The current estimation is quite satisfactory, in particular since it does not care about the (possibly complex) underlying streams. Also, I noticed that it is often quite precise for estimating the 10 last seconds.
  • Ogg file reading should be factorized along with the other file formats. This would have avoided this issue. However, this needs the implementation of multi-channel (audio+video) buffers, which should be done for 1.0

Changed 8 months ago by wiki

wrought iron<a href=" http://www.sellrails.info">stairparts</a> <a href=" http://www.shanhairail.info">stairparts</a> <a href=" http://www.whole-railing.info"> stairparts</a> <a href=" http://www.bestonlinemarketstore.info">railing</a>

Changed 2 weeks ago by metamorph68

(In [6691]) Added buffer's remaining time when computing estimated remaining time. fixes #295. Some remarks:

  • Adding precise estimated time is complicated, in particular due to the stream muxing.
  • The current estimation is quite satisfactory, in particular since it does not care about the (possibly complex) underlying streams. Also, I noticed that it is often quite precise for estimating the 10 last seconds.
  • Ogg file reading should be factorized along with the other file formats. This would have avoided this issue. However, this needs the implementation of multi-channel (audio+video) buffers, which should be done for 1.0

Changed 2 weeks ago by metamorph68

(In [6691]) Added buffer's remaining time when computing estimated remaining time. fixes #295. Some remarks:

  • Adding precise estimated time is complicated, in particular due to the stream muxing.
  • The current estimation is quite satisfactory, in particular since it does not care about the (possibly complex) underlying streams. Also, I noticed that it is often quite precise for estimating the 10 last seconds.
  • Ogg file reading should be factorized along with the other file formats. This would have avoided this issue. However, this needs the implementation of multi-channel (audio+video) buffers, which should be done for 1.0
Note: See TracTickets for help on using tickets.